The costumes are amazing, the choreography is solid and Cliff Edwards is likeable, but the leading man is a stalker as well as a womanizer which makes him unsympathetic, intentionally or not. The color scenes, while impressive for 1930, have the quality of a 1970s infomercial.
It's just okay, and it's interesting to see where "Should I?" came from.